This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] new hvm platform vhpet enable parameter

To: "dan.magenheimer@xxxxxxxxxx" <dan.magenheimer@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] new hvm platform vhpet enable parameter
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Thu, 14 Feb 2008 21:50:40 +0000
Delivery-date: Thu, 14 Feb 2008 13:51:11 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20080214124819656.00000001516@djm-pc>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AchpsV707M1mJgwlSGunlYGnJNsR0QAAQJ/OAADzrCAAAJFmswAEdqXAAVfVoBAAAit5rgAA1eiAAAJuWREAAC6qYAAE4Ne0
Thread-topic: [Xen-devel] [PATCH] new hvm platform vhpet enable parameter
User-agent: Microsoft-Entourage/
On 14/2/08 19:48, "Dan Magenheimer" <dan.magenheimer@xxxxxxxxxx> wrote:

>> It enables it by default if the tools do not explicitly
>> instruct either way.... for old saved guest images...
> OK, I see.  I'm glad you caught that.
> But does that mean if a guest config file does not explicitly
> have a "hpet = 0" line, the default will be on?  If so,
> that's different from how I intended.  Perhaps the
> code in XendDomainInfo _constructDomain should be modified
> to set it to zero if "hpet is None"?  Else, I'll bet
> guests created by virt-install will end up with hpet on.

Yes, that's possible. Possibly XendConfig.py should set a default. Or
virt-install itself should do so.

> Also it occurs to me it might be a good idea to add a
> gdprintk in hvm.c so that whether the hpet is on or not
> is visibly logged.

There are many config options for an HVM guest, none of which are logged by
Xen. It would be inconsistent to log just this one.

 -- Keir

Xen-devel mailing list