This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] [PATCH] fbfront: Fix no-kbd-event case

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH] fbfront: Fix no-kbd-event case
From: Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>
Date: Wed, 13 Feb 2008 16:03:16 +0000
Delivery-date: Wed, 13 Feb 2008 08:04:24 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Mail-followup-to: Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.12-2006-07-14
fbfront: Fix no-kbd-event case
out_cons shouldn't even be used.

Signed-off-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>

diff -r f76e90b4f7ad drivers/xen/fbfront/xenkbd.c
--- a/drivers/xen/fbfront/xenkbd.c      Tue Feb 12 10:44:33 2008 +0000
+++ b/drivers/xen/fbfront/xenkbd.c      Wed Feb 13 15:59:45 2008 +0000
@@ -53,7 +53,7 @@ static irqreturn_t input_handler(int rq,
        __u32 cons, prod;
        prod = page->in_prod;
-       if (prod == page->out_cons)
+       if (prod == page->in_cons)
                return IRQ_HANDLED;
        rmb();                  /* ensure we see ring contents up to prod */
        for (cons = page->in_cons; cons != prod; cons++) {

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>