This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] Prevent frontend network accelerator plugin load

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Prevent frontend network accelerator plugin loading in dom0
From: Kieran Mansley <kmansley@xxxxxxxxxxxxxx>
Date: Mon, 11 Feb 2008 15:33:45 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 11 Feb 2008 07:35:04 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <18352.24864.133392.889788@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1202481026.4147.27.camel@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <18352.24864.133392.889788@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Mon, 2008-02-11 at 14:52 +0000, Ian Jackson wrote:
> Kieran Mansley writes ("[Xen-devel] [PATCH] Prevent frontend network 
> accelerator plugin loading in dom0"):
> > Generate error if frontend plugin tries to connect on dom0
> If you're doing something with driver domains you might have frontends
> in dom0 and backends in the driver domain.  I don't think any of our
> current toolstack supports this but it would seem wrong to go out of
> our way to break it in the netfront driver.
> Or have I misunderstood the point of the change ?

It's there to mirror the existing check in netfront.c:netif.init():

  if (is_initial_xendomain())
    return 0;

i.e. If that test has failed, you've got no useful netfront
functionality, so having a plugin for it isn't much use, but netfront is
still present and the plugin could try and connect.  I'm just making it

In addition, the acceleration plugin stuff in netfront is only
initialised if you get past that test, so making sure it can only be
used if it's been initialised is a good idea. 

I'd be happy if someone wanted to remove these tests and make netfront
work in dom0 but I didn't want to make that more invasive change just


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>