This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] [PATCH] Remove misleading codes from XendDomainInfo.py

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH] Remove misleading codes from XendDomainInfo.py
From: Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>
Date: Fri, 08 Feb 2008 15:30:18 +0900
Delivery-date: Thu, 07 Feb 2008 22:31:33 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

I think that the following codes are misleading because 
xc_domain_setcpuweight() does not set cpuweight.  Currently we set 
cpuweight by using the functions in accordance with a scheduler type. 
Could you remove the following codes?

Signed-off-by: Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>

Best regards,

diff -r 8e4cd0658c41 tools/python/xen/xend/XendDomainInfo.py
--- a/tools/python/xen/xend/XendDomainInfo.py   Thu Feb 07 18:57:12 2008 +0000
+++ b/tools/python/xen/xend/XendDomainInfo.py   Fri Feb 08 13:25:18 2008 +0900
@@ -1750,9 +1750,6 @@ class XendDomainInfo:
             self.image = image.create(self, self.info)
-            xc.domain_setcpuweight(self.domid, \
-                                   self.info['vcpus_params']['weight'])
             # repin domain vcpus if a restricted cpus list is provided
             # this is done prior to memory allocation to aide in memory
             # distribution for NUMA systems.

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] Remove misleading codes from XendDomainInfo.py, Masaki Kanno <=