xen-devel

[Top] [All Lists]

[Xen-devel] blkback's st_wr_sect not properly accounted for barriers?

from [Samuel Thibault]

[Permanent Link][Original]

To:	xen-devel@xxxxxxxxxxxxxxxxxxx
Subject:	[Xen-devel] blkback's st_wr_sect not properly accounted for barriers?
From:	Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>
Date:	Thu, 7 Feb 2008 16:30:05 +0000
Delivery-date:	Thu, 07 Feb 2008 08:31:18 -0800
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Mail-followup-to:	Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent:	Mutt/1.5.12-2006-07-14

Hello,

It looks to me like the following patch is needed for proper accounting
in st_wr_sect, isn't it?

Signed-off-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>

diff -r 5c61cd349b20 drivers/xen/blkback/blkback.c
--- a/drivers/xen/blkback/blkback.c     Thu Feb 07 10:33:19 2008 +0000
+++ b/drivers/xen/blkback/blkback.c     Thu Feb 07 16:29:13 2008 +0000
@@ -509,7 +509,7 @@
 
        if (operation == READ)
                blkif->st_rd_sect += preq.nr_sects;
-       else if (operation == WRITE)
+       else if (operation == WRITE || operation == WRITE_BARRIER)
                blkif->st_wr_sect += preq.nr_sects;
 
        return;

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] blkback's st_wr_sect not properly accounted for barriers?, Samuel Thibault <=

Previous by Date:	Re: [Xen-devel] save/restore pass-through enabled domU, Daniel Stodden
Next by Date:	[Xen-devel] [PATCH] new hvm platform vhpet enable parameter, Dan Magenheimer
Previous by Thread:	[Xen-devel] Block WRITE_BARRIER / FLUSH_DISKCACHE operations and parameters, Samuel Thibault
Next by Thread:	[Xen-devel] [PATCH] new hvm platform vhpet enable parameter, Dan Magenheimer
Indexes:	[Date] [Thread] [Top] [All Lists]