This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [PATCH] hvm: Fix APIC-ID cpuid intercept

To: Andre Przywara <andre.przywara@xxxxxxx>
Subject: [Xen-devel] Re: [PATCH] hvm: Fix APIC-ID cpuid intercept
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Thu, 07 Feb 2008 08:19:48 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 07 Feb 2008 00:19:31 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <47AA3866.8050606@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AchpYjP9coPYqtVVEdymTgAWy6hiGQ==
Thread-topic: [PATCH] hvm: Fix APIC-ID cpuid intercept
User-agent: Microsoft-Entourage/
On 6/2/08 22:44, "Andre Przywara" <andre.przywara@xxxxxxx> wrote:

> the HVM CPUID intercept does not mask out the local APIC ID bits in
> CPUID Fn0000_0001, bits 24-31 in EBX. This results in inconsistent
> values of subsequent calls to cpuid on the same VCPU (delivering the
> value of the physical CPU), depending on the current scheduling. This
> for instance confuses Linux' NUMA code.
> The attached patch fixes this by replacing the physical APIC ID with the
> VCPU number, both in the VMX and SVM branches.
> Signed-off-by: Andre Przywara <andre.przywara@xxxxxxx>
> I hope this does not trigger any side effects...

I'm sure it can't do worse than the current broken behaviour!


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>