WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH][HVM] pass-through PCI device hotplug support

To: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH][HVM] pass-through PCI device hotplug support
From: "Zhai, Edwin" <edwin.zhai@xxxxxxxxx>
Date: Fri, 25 Jan 2008 11:06:13 +0800
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, "Zhai, Edwin" <edwin.zhai@xxxxxxxxx>
Delivery-date: Thu, 24 Jan 2008 19:08:36 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20080125014054.GM13888@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20080123155208.GA21201@xxxxxxxxxxxxxxxxxxxxxx> <20080124180656.GC2400@xxxxxxxxxx> <20080125013134.GG21201@xxxxxxxxxxxxxxxxxxxxxx> <20080125014054.GM13888@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.11
On Fri, Jan 25, 2008 at 01:40:54AM +0000, Daniel P. Berrange wrote:
> > 
> > I had the same idea at the beginning, but change mind due to some concerns:
> > 
> > xxx-attach/detach are used for _PV_ driver, but dpci is not the case.
> > If pci PV driver support hotplug in future, we get a complicated code path 
> > to 
> > handle both PV and dpci's hotplug.
> 
> I don't buy that argument. You can still just have completely separate
> codepaths inside XenD if you really need to - just switch on different
> impls in the main RPC dispatcher...
> 
>  def pci_attach()
>     if dom.is_hvm():
>        pci_attach_hvm()
>     else
>        pci_attach_pv()
> 
> Every part of Xen where we expose the user to a difference between HVM
> vs PV is a point of pain. We should ensure that use of HVM & PV is as 
> near as possible, identical from a user's view.

If we support PV driver in HVM guest with hotplug, the code path become more 
complicated:(

Anyway it's a trade off. I can change to pci_attach/detach for a simple user 
interface with complicated implementation.


> 
> > So do we have plan to support PCI PV driver hotplug? If no, we can use 
> > pci-attach/detach.
> 
> >From the user's point of view they are attaching & detaching PCI devices, 
> and they should not have to use separate commands to do the same operation
> for PV vs HVM.
> 
> Regards,
> Dan.
> -- 
> |=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
> |=-           Perl modules: http://search.cpan.org/~danberr/              -=|
> |=-               Projects: http://freshmeat.net/~danielpb/               -=|
> |=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 
> 

-- 
best rgds,
edwin

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel