 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] ioemu: handle empty vnc passwd
| To: | "Daniel P. Berrange" <berrange@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] ioemu: handle empty vnc passwd |
| From: | Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> |
| Date: | Wed, 23 Jan 2008 18:06:15 +0000 |
| Cc: | xen-devel@xxxxxxxxxxxxxxxxxxx, Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx> |
| Delivery-date: | Wed, 23 Jan 2008 10:07:16 -0800 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <20080123174942.GF17258@xxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | Achd6qTh40XtNsndEdyZHgAX8io7RQ== |
| Thread-topic: | [Xen-devel] [PATCH] ioemu: handle empty vnc passwd |
| User-agent: | Microsoft-Entourage/11.3.6.070618 |
On 23/1/08 17:49, "Daniel P. Berrange" <berrange@xxxxxxxxxx> wrote: > On Wed, Jan 23, 2008 at 05:46:33PM +0000, Keir Fraser wrote: >> If the only caller of xenstore_read_vncpasswd() is not checking the return >> code, why continue to have xenstore_read_vncpasswd() return an error code at >> all? >> >> If that is fixed, and Daniel Berrange will ack the patch, then I'll take it. > > ACK - patch gets my vote. Okay, actually I can just fix up read_vncpasswd to return void myself. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] ioemu: empty vnc passwd, Daniel P. Berrange |
|---|---|
| Next by Date: | [Xen-devel] Finding Your Own Domain Id, Adam Wick |
| Previous by Thread: | Re: [Xen-devel] [PATCH] ioemu: handle empty vnc passwd, Daniel P. Berrange |
| Next by Thread: | [Xen-devel] [PATCH] ioemu: cache the BlockDriverState pointer, Samuel Thibault |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
