WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 		  
Home Products Support Community News
 
   
 

xen-devel

[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

[Xen-devel] Re: [PATCH] Fix performance problems with mprotect()

from [Andi Kleen] [Permanent Link][Original]
To: "Bruce Rogers" <brogers@xxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] Fix performance problems with mprotect()
From: Andi Kleen <andi@xxxxxxxxxxxxxx>
Date: Mon, 07 Jan 2008 16:18:59 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 18 Jan 2008 10:30:30 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <477EAC09.5C6B.0048.1@xxxxxxxxxx> (Bruce Rogers's message of "Fri\, 04 Jan 2008 21\:49\:41 -0700")
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <477EAC09.5C6B.0048.1@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) 
"Bruce Rogers" <brogers@xxxxxxxxxx> writes:
> +
> +        /* Allowed to change in Accessed/Dirty flags only. */
> +        BUG_ON((t ^ old) & ~(intpte_t)(_PAGE_ACCESSED|_PAGE_DIRTY));


Are you sure that BUG_ON can't be triggered from the hypercall?
It should error out in this case I think.

-Andi

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  [Xen-devel] Re: [PATCH] [Xend] Fix 2 problems related to SR class, chetansa
Next by Date:  Re: [Xen-devel] migration and restore?, Daniel Stodden
Previous by Thread:  Re: [Xen-devel] [PATCH] Fix performance problems with mprotect(), Bruce Rogers
Next by Thread:  [Xen-devel] Re: [PATCH] Fix performance problems with mprotect(), Bruce Rogers
Indexes:  [Date] [Thread] [Top] [All Lists]
 
   

Copyright , Citrix Systems Inc. All rights reserved. Legal and Privacy