WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] "cpus" config parameter broken?

To: "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>, "Ian Pratt" <Ian.Pratt@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: RE: [Xen-devel] "cpus" config parameter broken?
From: "Dan Magenheimer" <dan.magenheimer@xxxxxxxxxx>
Date: Thu, 10 Jan 2008 15:53:21 -0700
Delivery-date: Thu, 10 Jan 2008 14:54:55 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C3AC50D2.1203A%Keir.Fraser@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Oracle Corporation
Reply-to: "dan.magenheimer@xxxxxxxxxx" <dan.magenheimer@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AchRkyjajMDoVQVpQRWI8qTGrlL9cgABaF9AAFMFs1AAA9YWgwAwdYQQAAUX2kQAAE0noAACC6lUAAAz/oAAAYJBbgAAFC5A
> > So modulo-izing the cpus parameter code will eliminate this
> > case, but I still wonder if vcpu_set_affinity should reject any
> > mask that has bits set beyond max_pcpu instead of silently
> > ignoring those bits.  Seems like an accident waiting to happen
> > and indeed I got bitten by it.
> >
> > Which is why I proposed tightening the definition of all affinity
> > masks (and strings representing masks) to "if you try to enable
> > a bit in the cpumask that refers to a non-existent processor, you
> > will get an error"
> 
> That doesn't play nicely with CPU hotplug (not supported yet, 
> but could well
> be in future) where the online_map could be continually 
> changing. The model
> I'm aiming for in Xen is to remember all the CPUs requested by the
> toolstack, but only schedule onto the subset that are 
> actually online right
> now (obviously). The implementation of this is of course 
> quite simple given
> the CPU hotplug is not supported right now.

Agreed, but even with CPU hotplug there will be some max_pcpu value
on any given machine.  That's why I said "non-existent processor"
in the proposal even though you said "offline processor".

Dan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel