This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] [PATCH][NET] Handle netdev secondary addresses and labels

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH][NET] Handle netdev secondary addresses and labels
From: Mark McLoughlin <markmc@xxxxxxxxxx>
Date: Thu, 03 Jan 2008 14:29:44 +0000
Delivery-date: Thu, 03 Jan 2008 06:30:17 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Red Hat Ltd. Registered Address: Red Hat Ltd, Brian O' Donnell and Partners, 62 Merrion Square, Dublin 2, Ireland. Registered in the Companies Registration Office, Parnell House, 14 Parnell Square, Dublin 1, Ireland, at No. 304873 Directors: Charlie Peters (USA), Michael Cunningham (USA), Matt Parson (USA), Brendan Lane
Reply-to: Mark McLoughlin <markmc@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Fix the network-bridge logic to correctly transfer secondary IP address
from $netdev to $bridge.

e.g. if you add an secondary address/label/alias with:

  $> ip addr add dev eth0 label eth0:00

then, "ip addr show dev eth0" gives e.g.:

  inet brd scope global eth0
  inet scope global secondary eth0:00

and transfer_addrs() tries to execute:

  ip addr add brd scope global dev tmpbridge
  ip addr add scope global secondary dev tmpbridge:00

which causes the sript to fail because:

  1) The device tmpbridge:00 doesn't exist
  2) The "secondary" flag isn't valid

This patch fixes the sed commands to instead give:

  ip addr add brd scope global dev tmpbridge label 
  ip addr add scope global dev tmpbridge label tmpbridge:00

Signed-off-by: Mark McLoughlin <markmc@xxxxxxxxxx>

Attachment: xen-network-bridge-handle-secondary-addresses.patch
Description: Text Data

Xen-devel mailing list
<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH][NET] Handle netdev secondary addresses and labels, Mark McLoughlin <=