Re: RFC: unaligned and page-crossing writes in shadow emulate ca

To:	"Tim Deegan" <Tim.Deegan@xxxxxxxxxx>
Subject:	Re: RFC: unaligned and page-crossing writes in shadow emulate callbacks (was Re: [Xen-devel] Question about alignment check in sh_x86_emulate_write)
From:	"Trolle Selander" <trolle.selander@xxxxxxxxx>
Date:	Mon, 10 Dec 2007 14:54:22 +0100
Cc:	"Su, Disheng" <disheng.su@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date:	Mon, 10 Dec 2007 05:55:01 -0800
Dkim-signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:references; bh=Lc1C9WXA2lVwIoc2Vr/XLJkGUPrMyqzGSyrRStTyFUI=; b=TuNCq6+Z1Glcf/FzGt2APj9tcfG1Pbd1/AR39JkJ8FMa63EznPy76wtJWFLYprfCfaMVdksh62FrKQN89wKznO6XGuEyfvx0M5kY4tiumEtBCyVx9aJ5hp8BE/1bEzinQwQxo0yZak3seews2S8rnhB8LnCTkucUvsUSjBvI9OU=
Domainkey-signature:	a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:references; b=x9iRoNWm2RfCn6mGnAF+O0B6pi/R1Elx64+8Uw2zagvAzr1eX/nDCFgk/RjjZzVI+plWpQvr4pUOjnGful+FtMPkXpbCyhbpOehw0jyS6xRL9Ix0u5hxperY50aAHnPSbLwlHu+LvfrDOX0sPPCtMnkUaq1GUhsBFiyb7eS+hKI=
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
In-reply-to:	<20071206142740.GB4757@xxxxxxxxxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<FF386CB4AE0E4648B0A96060EC00F36C5BB8FA@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20071204124334.GB2062@xxxxxxxxxxxxxxxxxxxxx> <FF386CB4AE0E4648B0A96060EC00F36C5BB8FB@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20071204133319.GC2062@xxxxxxxxxxxxxxxxxxxxx> <20071206142740.GB4757@xxxxxxxxxxxxxxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

This fixes the issue for the OS/2 case, at least.

On Dec 6, 2007 3:27 PM, Tim Deegan <Tim.Deegan@xxxxxxxxxx> wrote:

Hi,

At 13:33 +0000 on 04 Dec (1196775199), Tim Deegan wrote:
> Yes, but you'll probably find you need page-crossing support as well if
> you're emulating arbitrary memory writes. I believe we have a patch
> somewhere that does that; I'll dig it out and polish it up for -unstable.

Attached. I took the opportunity to tidy up a bit and move more shared
code out of the write/cmpxchg/cmpxchg8b callbacks into helpers. This is
smoke-tested but I don't have a test case for your virus-scanner's
behaviour. Can you check that (a) it seems sane for what you want, and
(b) it actually does something useful?

Cheers,

Tim.

--
Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Principal Software Engineer, Citrix Systems.
[Company #5334508: XenSource UK Ltd, reg'd c/o EC2Y 5EB, UK.]

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

Re: RFC: unaligned and page-crossing writes in shadow emulate callbacks