WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [Xen-staging] [xen-unstable] [QEMU-DM] Upgrade emulated

To: "Alex Williamson" <alex.williamson@xxxxxx>
Subject: [Xen-devel] Re: [Xen-staging] [xen-unstable] [QEMU-DM] Upgrade emulated UART to 16550A.
From: "Trolle Selander" <trolle.selander@xxxxxxxxx>
Date: Wed, 5 Dec 2007 23:07:20 +0100
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 05 Dec 2007 14:08:11 -0800
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:references; bh=8ig+t27PhNr7b4u3dXLrrIkvXDwF1wcMApzsLuhQcxM=; b=s07IVWBTuZq31HsGC2qjrffrYjlvYElwBLV1ogSVb0YBA8FcLOf0taYbgItG18Fu+kPffYf+hzS6ppwRvaAaMLU479AUyRQdbbQEuZ6I3fLOcfl7JWw+9i/VazUgR5NJRRO17FKGu1PamyGwTb18LQ2cVyr9fdZghHbKtcFwZ20=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:references; b=SCUnJshyDqWM0gtYsffo5Ml9ZHyS3URIyLqtzF/WZOXfhmhAtxnSIGiV/8adl0ZNiIkIQq+ZsigKxA7pljnw3Fn3Hz3VB2F2CqfBkYcDRZoEP0FUGq3wn355IqfN11U4P8R+i/pPqnB+t7sNOqgnEcXGPYQAf1+/go/qAubqFs8=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <515922b50712051230w1876610blb75937b1d224858e@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <200712051422.lB5EMOK6007392@xxxxxxxxxxxxxxxxxxxxxxx> <1196885729.6509.36.camel@lappy> <515922b50712051230w1876610blb75937b1d224858e@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
This patch fixes the issue. It also changes the name of an inappropriately named timer.

Signed-off-by: Trolle Selander <trolle.selander@xxxxxxxxx>

On Dec 5, 2007 9:30 PM, Trolle Selander < trolle.selander@xxxxxxxxx> wrote:
As you describe this, it does occur to me as you describe this that serial_xmit() never gives up on trying to retransmit characters out of the FIFO, which isn't very good for backends like pty's or pipes. I'll fix it asap.


On Dec 5, 2007 9:15 PM, Alex Williamson <alex.williamson@xxxxxx> wrote:

On Wed, 2007-12-05 at 14:22 +0000, Xen staging patchbot-unstable wrote:
> # HG changeset patch
> # User Keir Fraser
> # Date 1196864460 0
> # Node ID f0ac46de680cc6fe8c91699fdda153b125ae515c
> # Parent  bf21e00155b7dd76653c5340099ecedac7a7de08
> [QEMU-DM] Upgrade emulated UART to 16550A.
>
> This patch adds 16550 emulation to qemu-dm. I still consider it a work
> in progress, but from my testing, it consistently performs better than
> the old code already, sometimes considerably so (on my laptop, dumping
> out data over serial from a HVM DomU -> pty in Dom0 was up to 5.3
> times faster than with the old 16450 code). I can consistenly reach
> full 115200 baud speeds over physical serial lines when the virtual
> device is backed by a phys port, which I never could with the old code.
>
> There are still some things to be done. I want to add proper error
> handling, so that overflow/framing & parity errors on the physical
> port get detected and reported by the virtual port. Also, now that
> FIFOs are in place, I believe performance could be improved
> significantly by putting some code into the hypervisor so that reads &
> writes from the FIFOs don't have to exit into qemu-dm at all. I'm also
> reading up on the specs for newer uarts with deeper FIFOs.

  I notice with this patch that my HVM domain, which specifies
serial=pty in the config file, no longer boots without me attaching to
the console via xm.  Previously it would boot regardless of whether I
was attached to the console.  Is this change in behavior intentional?
Note that I'm testing on ia64 where the HVM firmware spews lots of debug
info out onto the serial port.  Maybe this new UART model isn't dropping
transmit chars when there's no client connected as it did before?
Thanks,

       Alex

--
Alex Williamson                             HP Open Source & Linux Org.



Attachment: xen-qemudm-16550A-limit-retransmit.patch
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel