WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [Patch] fix canonicalize-existing vbd file

Akio Takebe writes ("Re: [Xen-devel] [Patch] fix canonicalize-existing vbd 
file"):
> How about the attached new patch?
...
>          file=$(readlink -f "$p") || fatal "$p does not exist."
> +        test -f "$file" || fatal "$file does not exist."
>          mode=$(canonicalise_mode "$mode")

That looks reasonable to me.

Ian.

PS: it would be slightly better in general to have error distinct and
therefore distinguishable error messages.  But that doesn't seem very
important here.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel