WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH][HVM] Fix 2 type mismatches in vlapic.h andhpet.c

To: "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>, "xen-devel" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH][HVM] Fix 2 type mismatches in vlapic.h andhpet.c for 32-bit build Xen
From: "Cui, Dexuan" <dexuan.cui@xxxxxxxxx>
Date: Tue, 27 Nov 2007 12:01:45 +0800
Delivery-date: Mon, 26 Nov 2007 20:04:31 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <FE7BBCFBB500984A9A7922EBC95F516E70F57D@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <FE7BBCFBB500984A9A7922EBC95F516E70F57D@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcgwqGajcxL9lyZSSkG/2aFRcODxtwAAYgZA
Thread-topic: [Xen-devel] [PATCH][HVM] Fix 2 type mismatches in vlapic.h andhpet.c for 32-bit build Xen
Cui, Dexuan wrote:
> For 32-bit build of Xen,
> 1) the first mismatch (in hpet_read(), length is 4)  makes guest think
> the HPET DM is buggy (we return 0 for HPET_CFG.COUNTER_CLK_PERIOD to
> guest), so guest wouldn't use HPET at all.
> 2) the second one: if tmict is 62500000 and timer_divisor is 16
> (Fedora7's installer uses the values at some time), 10 * 62500000 *
> 16 = 0x2540BE400 -- it's too big to be held in uint32_t.
> 
> Signed-off-by: Dexuan Cui <dexuan.cui@xxxxxxxxx>

Please use this new patch.
The first patch omits one other place in vlapic.c :)

-- Dexuan

Attachment: fix_type_mismatch_for_32bit_xen.patch
Description: fix_type_mismatch_for_32bit_xen.patch

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>