WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] [Mini-OS] Fix domain blocking race

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH] [Mini-OS] Fix domain blocking race
From: Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>
Date: Fri, 23 Nov 2007 18:15:41 +0000
Delivery-date: Fri, 23 Nov 2007 10:16:19 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Mail-followup-to: Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.12-2006-07-14
A callback which wakes a thread may happen between the moment schedule()
gives hand to the idle thread and the latter blocks the domain.  Idle
hence needs to atomically check that no thread is running and block,
else awoken threads may have to wait up to 10 seconds.

Signed-off-by: Samuel Thibault <samuel.thibault@xxxxxxxxxx>

diff -r dc9246357cdb extras/mini-os/sched.c
--- a/extras/mini-os/sched.c    Fri Nov 23 16:42:44 2007 +0000
+++ b/extras/mini-os/sched.c    Fri Nov 23 18:11:18 2007 +0000
@@ -216,12 +216,29 @@
 void idle_thread_fn(void *unused)
 {
     s_time_t until;
+    unsigned long flags;
+    struct list_head *iterator;
+    struct thread *next, *thread;
     for(;;)
     {
         schedule();
-        /* block until the next timeout expires, or for 10 secs, whichever 
comes first */
-        until = blocking_time();
-        block_domain(until);
+        next = NULL;
+        local_irq_save(flags);
+        list_for_each(iterator, &idle_thread->thread_list)
+        {
+            thread = list_entry(iterator, struct thread, thread_list);
+            if(is_runnable(thread)) 
+            {
+                next = thread;
+                break;
+            }
+        }
+        if (!next) {
+            /* block until the next timeout expires, or for 10 secs, whichever 
comes first */
+            until = blocking_time();
+            block_domain(until);
+        }
+        local_irq_restore(flags);
         wake_expired();
     }
 }

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] [Mini-OS] Fix domain blocking race, Samuel Thibault <=