WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Re: Xend transaction reduction breaks migration

To: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
Subject: Re: [Xen-devel] Re: Xend transaction reduction breaks migration
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Thu, 15 Nov 2007 22:11:29 +0000
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 15 Nov 2007 14:12:27 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C362447B.1883F%Keir.Fraser@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acgnt89FDYp0uJOrEdy0XAAX8io7RQAHKlVX
Thread-topic: [Xen-devel] Re: Xend transaction reduction breaks migration
User-agent: Microsoft-Entourage/11.3.6.070618
On 15/11/07 18:46, "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx> wrote:

> On 15/11/07 18:39, "Daniel P. Berrange" <berrange@xxxxxxxxxx> wrote:
> 
>> all happen in one large transaction. Oddly though, I tried to be careful so
>> that I only changed the codepath for the 'xm list' operation (well the SEXPR
>> call to the list operation). Other operations like create, save, restore
>> ought to be left using fine grained transactions as before.
> 
> I'll have another look at nearby changesets in xen-unstable then. Yours
> doesn't really look all that likely to cause this problem, except that the
> empirical evidence does point at it.

It is your patch. The readDomTxn() functions and friends should prepend the
dompath, not the vmpath.

We wouldn't notice this normally since self.console_port is not actually
really used after domain building. So we have to race the migration thread
to get the assertion to fire, and that happens fairly rarely.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel