WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] x86: usercopy assembly constraints

To: Jan Beulich <jbeulich@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] x86: usercopy assembly constraints
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Tue, 13 Nov 2007 20:28:41 +0000
Delivery-date: Tue, 13 Nov 2007 12:29:29 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C35FB77E.185D0%Keir.Fraser@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcgmMpkq2AK3tZIlEdytjwAX8io7RQAAS4xm
Thread-topic: [Xen-devel] [PATCH] x86: usercopy assembly constraints
User-agent: Microsoft-Entourage/11.3.6.070618
On 13/11/07 20:20, "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx> wrote:

> On 13/11/07 16:02, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:
> 
>> Besides only being correct this way, this helps work around a gcc 4.3
>> issue.
>> At the same time, add some white space, re-order the inputs, and remove
>> a bogus cast.
> 
> What's the bug? Does some gcc allocate the 4th output parameter into one of
> the other used registers (cx,si,di) if we don't use '=&'?

If this is the case, it sounds to me like a gcc bug (allocating two outputs
into the same register) and it could potentially hit on a number of our
other asm statements I'm pretty sure.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel