WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 		  
Home Products Support Community News
 
   
 

xen-devel

[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

Re: [Xen-devel] [VTD][PATCH] Correct PCI_EXP_DEVCTL_FLR

from [Alex Williamson] [Permanent Link][Original]
To: "Han, Weidong" <weidong.han@xxxxxxxxx>
Subject: Re: [Xen-devel] [VTD][PATCH] Correct PCI_EXP_DEVCTL_FLR
From: Alex Williamson <alex.williamson@xxxxxx>
Date: Wed, 07 Nov 2007 08:56:18 -0700
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, "Kay, Allen M" <allen.m.kay@xxxxxxxxx>
Delivery-date: Wed, 07 Nov 2007 07:57:28 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <08DF4D958216244799FC84F3514D70F0BB24F8@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: OSLO R&D
References: <08DF4D958216244799FC84F3514D70F0BB24F8@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx 
On Wed, 2007-11-07 at 11:29 +0800, Han, Weidong wrote:
> This patch corrects PCI_EXP_DEVCTL_FLR so that function level reset will
> be really executed, and also replaces some magic numbers with micro.

   PAGE_SHIFT/SIZE/MASK shouldn't be used in userspace so freely.
AFAICT, this breaks the build on x86_64 and ia64.  Ideally we should use
getpagesize().  If that doesn't work, at least define them to the
defaults locally like in toosl/ioemu/hw/iommu.c.  Thanks,

        Alex

-- 
Alex Williamson                             HP Open Source & Linux Org.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  [Xen-devel] xend "sysctl operation failed", Aron Griffis
Next by Date:  [Xen-ia64-devel] Re: [Xen-devel] xend "sysctl operation failed", Keir Fraser
Previous by Thread:  Re: [Xen-devel] [VTD][PATCH] Correct PCI_EXP_DEVCTL_FLR, Keir Fraser
Next by Thread:  [Xen-devel] [PATCH]Enable loopback disk image files on readonly nfs filesystem, Zhignag Wang
Indexes:  [Date] [Thread] [Top] [All Lists]
 
   

Copyright , Citrix Systems Inc. All rights reserved. Legal and Privacy