Re: [Xen-devel] [PATCH] Add a timer mode that disables pending missed ticks

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 3/11/07 21:17, "Dave Winchell" <dwinchell@xxxxxxxxxxxxxxx> wrote:

> Thanks for applying the fixes in the last submit.
> In moving the test for no_missed_tick_accounting into
> pt_process_missed_ticks()
> you forgot to add the scheduling part.

Actually it was deliberate, but clearly it was one code simplification too
far: thanks for spotting it! I'll go the async route, but we do need to set
pending_intr_nr to 1. We can't leave that out -- the point of the async
route is to send a tick to the vcpu immediately, since it hasn't had one for
more than a tick period. If we wait for the timeout to do that then we have
to wait a whole extra period after the vcpu is re-scheduled.

Attached is my proposed patch. I think it's quite neat. :-)

 -- Keir

timer.patch
Description: Binary data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel