Re: [Xen-devel] Re: "portable" sh is not...

[John Levon <levon@xxxxxxxxxxxxxxxxx>]

On Tue, Oct 23, 2007 at 02:27:07PM +0200, Christoph Egger wrote:

> On Tuesday 23 October 2007 14:20:14 John Levon wrote:
> > On Tue, Oct 23, 2007 at 02:14:38PM +0200, Christoph Egger wrote:
> > > > http://xenbits.xensource.com/staging/xen-unstable.hg?rev/08295dc13166
> > > >
> > > > broke our build. The script is not portable as claimed (e.g.
> > > > traditional Bourne shell has no $( ... ) construct).
> > >
> > > The only one bash-specific thing I could find was the [:alpha:] notion.
> > > This changeset makes it work on BSD's /bin/sh.
> > > Looks like BSD's /bin/sh is not that traditional... :)
> 
> Looking through get-fields.sh, it seems the $( ... ) constructs can be
> replaced with backticks. This should make Solaris' /bin/sh happy.

vim is highlighting stuff like

                                        type=${token#COMPAT_HANDLE?}
                                        type=${type%?}
                                        type=${type#compat_}

as bad, but I don't know what those constructs do.

regards
john

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel