RE: [Xen-devel] cpufreq: weird bug in set_time_scale

To:	"Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>, "Jean Pihet" <jpihet@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Subject:	RE: [Xen-devel] cpufreq: weird bug in set_time_scale
From:	"Langsdorf, Mark" <mark.langsdorf@xxxxxxx>
Date:	Thu, 11 Oct 2007 14:45:20 -0500
Delivery-date:	Thu, 11 Oct 2007 12:46:26 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
In-reply-to:	<C3342AA9.EBDA%Keir.Fraser@xxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<200710112014.43834.jpihet@xxxxxxxxxx> <C3342AA9.EBDA%Keir.Fraser@xxxxxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index:	AcgMNP6jPWyOvngoEdyk1QAWy6hiGQACjKZQ
Thread-topic:	[Xen-devel] cpufreq: weird bug in set_time_scale

> Yep, that case is not acceptable for the DIV instruction, 
> because it causes overflow of the quotient. It's fixed
> by xen-unstable changeset 16098.
> 
> It's a one-char fix: the loop on (tps32 < MILLISECS(1000))
> needs to be (tps32 <= MILLISECS(1000)).

Thanks, that fixed it.

-Mark Langsdorf
Operating System Research Center
AMD



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

RE: [Xen-devel] cpufreq: weird bug in set_time_scale