This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH][TOOLS] ioemu: Build fixes for BSD and bug fixes

To: "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH][TOOLS] ioemu: Build fixes for BSD and bug fixes from BSD
From: "Christoph Egger" <Christoph.Egger@xxxxxxx>
Date: Fri, 28 Sep 2007 10:07:23 +0200
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 28 Sep 2007 01:09:52 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C3218D36.16153%Keir.Fraser@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C3218D36.16153%Keir.Fraser@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.9.6
On Thursday 27 September 2007 17:39:18 Keir Fraser wrote:
> On 27/9/07 12:35, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:
> > Hi!
> >
> > Attached patch makes ioemu build on *BSD.
> > It also applies bug fixes from *BSD for Linux and *BSD :-)
> >
> > Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>
> I checked in all the bits that look like they are there just to make ioemu
> build and run on *BSD (that's about 90-95% of the patch). The remainder I
> rejected -- that's generic bug fixes to ioemu (belongs upstream and/or as
> separate patches to xen-devel) and anything that looked like it merely
> fixes a build warning (we don't build ioemu with -Werror, and we tolerate
> build warnings because they should really be fixed upstream first).

I agree with you, this also should go into qemu. But I don't have contact to
the qemu people. That's why I asked in the first signed-off mail, if there is
someone with contact to qemu.
Maybe someone from qemu is subscribed on xen-devel, so I resubmit
the remainder as separate patch.

Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>

> You may want to check that I didn't cut too hard, and resubmit a few bits.
>  -- Keir

I just checked. I can live with that what you committed. But I resubmit
the remainder for the case someone from qemu is on xen-devel or
someone with contact to qemu people is on xen-devel, in hope the
*full* patch goes into qemu the one or the other way.


AMD Saxony, Dresden, Germany
Operating System Research Center

Legal Information:
AMD Saxony Limited Liability Company & Co. KG
Sitz (Geschäftsanschrift):
   Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland
Registergericht Dresden: HRA 4896
vertretungsberechtigter Komplementär:
   AMD Saxony LLC (Sitz Wilmington, Delaware, USA)
Geschäftsführer der AMD Saxony LLC:
   Dr. Hans-R. Deppe, Thomas McCoy

Attachment: tools_ioemu2.diff
Description: Text document

Xen-devel mailing list