This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] [PATCH][TOOLS] firmware: fix romimage generation

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH][TOOLS] firmware: fix romimage generation
From: "Christoph Egger" <Christoph.Egger@xxxxxxx>
Date: Tue, 25 Sep 2007 13:55:40 +0200
Delivery-date: Tue, 25 Sep 2007 04:57:41 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.9.6

Attached patch makes the following changes:
- portability fix in Makefile: mkhex is not bash specific
- GNU od separates column with one blank, BSD od uses eight blanks.
  Change sed to deal with this.
- Add a fourth sed to fix the following build error on NetBSD:

gcc -I../../../tools/libxc -I. -m32 -march=i686 -DNDEBUG -fno-strict-aliasing 
-std=gnu99 -Wall -Wstrict-prototyp
es -Wno-unused-value -Wdeclaration-after-statement  -D__XEN_TOOLS__  
mno-tls-direct-seg-refs  -fno-stack-protector  -fno-builtin -O2 -msoft-float -c 
hvmloader.c mp_tables.c util.c s
mbios.c 32bitbios_support.c
In file included from 32bitbios_support.c:33:
../rombios/32bit/32bitbios_flat.h:818:13: error: invalid suffix "x" on integer 

- Add a fifth sed to eliminate the offset column (= 1st column) printed in the 
last line. Example:

od -v -t x ../rombios/BIOS-bochs-latest | less
<last 3 lines>
0177740 00000000 00000000 00000000 00000000
0177760 00e05bea 2f3630f0 392f3332 12fc0039
0200000     <-- Eliminate this

Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>

P.S.: Is there a reason for having mkhex twice?

AMD Saxony, Dresden, Germany
Operating System Research Center

Legal Information:
AMD Saxony Limited Liability Company & Co. KG
Sitz (Geschäftsanschrift):
   Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland
Registergericht Dresden: HRA 4896
vertretungsberechtigter Komplementär:
   AMD Saxony LLC (Sitz Wilmington, Delaware, USA)
Geschäftsführer der AMD Saxony LLC:
   Dr. Hans-R. Deppe, Thomas McCoy

Attachment: tools_firmware.diff
Description: Text document

Xen-devel mailing list
<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH][TOOLS] firmware: fix romimage generation, Christoph Egger <=