This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] Default serial console to BAUD_AUTO

To: John Levon <john.levon@xxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Default serial console to BAUD_AUTO
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Mon, 24 Sep 2007 21:22:20 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 24 Sep 2007 13:18:09 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20070924194043.GA24987@xxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acf+6Jud2hamyGrbEdyQ6gAWy6hiGQ==
Thread-topic: [Xen-devel] [PATCH] Default serial console to BAUD_AUTO
User-agent: Microsoft-Entourage/
On 24/9/07 20:40, "John Levon" <john.levon@xxxxxxx> wrote:

>> and, really, you can just put 'com1=auto' on your command
>> line to get the same effect and then noone gets surprised by Xen locking
>> down serial ports when com1/com2 does not appear on their Xen command line.
> Fair enough, we should not use the serial console by default (although at
> least
> Solaris will feed output through HYPERVISOR_console_io if Xen's already
> grabbed
> it). However, I don't think that the current *code* (whereby the serial
> console
> gets disabled as a side effect of not setting BAUD_AUTO, and OPT_CONSOLE_STR
> does not do what it appears to do) is readable or maintainable. Can we please
> make the intention of the code clear?
> Neither do I think that forcing users to unnecessarily set "com1=auto" is good
> UI.

I can cook up something appropriate I think.

 -- Keir

Xen-devel mailing list