This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] libfsimage: Make it build on NetBSD

To: John Levon <levon@xxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] libfsimage: Make it build on NetBSD
From: Bastian Blank <bastian@xxxxxxxxxxxx>
Date: Sun, 23 Sep 2007 13:15:20 +0200
Cc: Christoph Egger <Christoph.Egger@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Sun, 23 Sep 2007 04:16:00 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20070921154732.GC23965@xxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <200709211439.46415.Christoph.Egger@xxxxxxx> <20070921154732.GC23965@xxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.13 (2006-08-11)
On Fri, Sep 21, 2007 at 04:47:32PM +0100, John Levon wrote:
> On Fri, Sep 21, 2007 at 02:39:46PM +0200, Christoph Egger wrote:
> > -  if (!*dirname || isspace (*dirname))
> > +  if (!*dirname || isspace ((uint8_t)*dirname))
> Eww, surely not. This surely can't give a warning on NetBSD?

It can if it is implemented as something like:
| int char_isspace[] = {...];
| #define isspace(c) char_isspace[c]


        "Get back to your stations!"
        "We're beaming down to the planet, sir."
                -- Kirk and Mr. Leslie, "This Side of Paradise",
                   stardate 3417.3

Xen-devel mailing list