This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] [PATCH] Add 'type vnc' to vfb device sexpr for HVM guest

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH] Add 'type vnc' to vfb device sexpr for HVM guest
From: Jim Fehlig <jfehlig@xxxxxxxxxx>
Date: Mon, 10 Sep 2007 15:07:00 -0600
Delivery-date: Mon, 10 Sep 2007 14:07:36 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird (X11/20060911)
This patch adds 'type vnc' to vfb device sexpr for HVM guests.  PV
guests already contain this entry in sexpr, e.g.

            (vncunused 1)
           (type vnc)

Some tools, such as libvirt, look for device/vfb/type in sexpr before
publishing VNC port.  More importantly, this patch provides consistency
in vfb device sexpr between HVM and PV guests.

Signed-off-by: Jim Fehlig <jfehlig@xxxxxxxxxx>


diff -r 9071521d4864 tools/python/xen/xend/XendConfig.py
--- a/tools/python/xen/xend/XendConfig.py       Fri Sep 07 11:39:10 2007 +0100
+++ b/tools/python/xen/xend/XendConfig.py       Fri Sep 07 17:17:30 2007 -0600
@@ -752,6 +752,7 @@ class XendConfig(dict):
             if not has_rfb:
                 dev_config = ['vfb']
+                dev_config.append(['type', 'vnc'])
                 # copy VNC related params from platform config to vfb dev conf
                 for key in ['vncpasswd', 'vncunused', 'vncdisplay',
Xen-devel mailing list
<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] Add 'type vnc' to vfb device sexpr for HVM guest, Jim Fehlig <=