WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Re: [XenPPC] [PATCH 2/7] xencomm take 3: xen side prepar

To: Hollis Blanchard <hollisb@xxxxxxxxxx>
Subject: Re: [Xen-devel] Re: [XenPPC] [PATCH 2/7] xencomm take 3: xen side preparetion for consolidation.
From: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>
Date: Wed, 15 Aug 2007 12:46:05 +0900
Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 14 Aug 2007 20:46:30 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1187102880.30063.4.camel@basalt>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20070814095023.GA27679%yamahata@xxxxxxxxxxxxx> <1187102880.30063.4.camel@basalt>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.4.2.1i
On Tue, Aug 14, 2007 at 09:48:00AM -0500, Hollis Blanchard wrote:

> However, there are a few places below where you call memcpy() without
> checking the result of xencomm_maddr_to_vaddr(). Actually, I see the
> same issue in the original code in a few places... We should be very
> very careful here, since a guest passing a bad paddr could result in Xen
> overwriting 0x0.

Thank you for comments. The next patch (3/7) addresses those issues.
i.e. checking guest supplied values, avoiding races.
I intentionally kept this patch(2/7) as small as possible leaving them
to the next patch (3/7).

Since we can work around the populate physmap issue,
it's ok for me to drop multi page support.
But we need the next patch or something similar.
If you dislike the implementation, I'm willing to refine it.
Please suggest.
-- 
yamahata

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel