WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Fix xm block/network-detach command (take2)

To: Jim Fehlig <jfehlig@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Fix xm block/network-detach command (take2)
From: Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>
Date: Fri, 10 Aug 2007 17:59:19 +0900
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, mats@xxxxxxxxxxxxxxxxx
Delivery-date: Fri, 10 Aug 2007 02:00:06 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <46BB61A3.7010903@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <46BB61A3.7010903@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Hi Jim,

Thanks for your tests.

>I tested your patch briefly on c/s 15672.
<snip>
>The device was unplugged but its config not removed. From xend.log:
>
>File "/usr/lib64/python2.4/xen/xend/XendDomainInfo.py", line 615, in
>destroyDevice
>self.info['%s_refs' % deviceClass].remove(dev_uuid)
>KeyError: 'tap_refs'
>
>I think refs for the various disk types all fall under 'vbd_refs'.

I tested blktap with the same way as your operation.  But I did not 
encounter the command error as follows. 
But your thinking is right, so I wrote a small patch to remove the 
error message.  Could you test the patch again? 

# xm list
Name                                        ID   Mem VCPUs      State   Time(s)
Domain-0                                     0   747     2     r-----     89.9
vm1                                          1   256     1     -b----      0.7
# xm block-list vm1
Vdev  BE handle state evt-ch ring-ref BE-path
769    0    0     4      6      8     /local/domain/0/backend/vbd/1/769  
# xm block-attach vm1 tap:aio:/xen/second.img xvdb r
# xm block-list vm1
Vdev  BE handle state evt-ch ring-ref BE-path
769    0    0     4      6      8     /local/domain/0/backend/vbd/1/769  
51728    0    0     4      8      836   /local/domain/0/backend/tap/1/51728  
# xm block-detach vm1 xvdb
# xm block-list vm1
Vdev  BE handle state evt-ch ring-ref BE-path
769    0    0     4      6      8     /local/domain/0/backend/vbd/1/769  


>Also, when trying to detach a disk that a pv domU has mounted, I get
>this error (after 100 second timeout):
<snip>
>The behavior is fine (i.e. the disk is still attached and remains in
>stored config) but the error message is misleading. xvbd is connected,
>its just the front-end won't let go AFAIK.

I'd like to improve the error message.  Could you give me thinking 
time about 2 weeks? 


Signed-off-by: Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>

Best regards,
 Kan

Attachment: fix_staging_cs15716.patch
Description: Binary data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel