Re: [Xen-devel] compile error of HVM pv drivers

[Mats Petersson <mats@xxxxxxxxxxxxxxxxx>]

At 10:58 30/07/2007, Kieran Mansley wrote:
> On Mon, 2007-07-30 at 17:28 +0800, Zhao, Yunfeng wrote:
> > With gcc 3.4.2 I got following errors while compiling HVM pv drivers
> > against xen unstable 15651.
> > #################
> > /xen-3.0-hg-xen_unstable_pae-15651-20070727/unmodified_drivers/linux-2.6
> > /netfront/accel.c: In function `accelerator_remove_hooks':
> > xen-3.0-hg-xen_unstable_pae-15651-20070727/unmodified_drivers/linux-2.6/
> > netfront/accel.c:495: error: syntax error before "do"
> > xen-3.0-hg-xen_unstable_pae-15651-20070727/unmodified_drivers/linux-2.6/
> > netfront/accel.c:495: error: syntax error before ')' token
> > ###################
> > But on rhel5 (gcc 4.1.1), the build can pass without any error.
>
> Curious.  Can you post what code you have at that line.  In my recent
> checkout it looks like this:
>
> 490:    list_for_each_entry_safe(vif_state, tmp,
> 491:                            &accelerator->vif_states,
> 492:                            link) {
> 493:            /* Make sure there are no data path operations going on */
> 494:            netif_poll_disable(vif_state->np->netdev);
> 495:            netif_tx_lock_bh(vif_state->np->netdev);
Unless one of those lines is a macro that uses the "do { ... } 
while(0)" trick, perhaps - how about looking at the preprocessor 
output for those lines?
--
Mats


> Which doesn't seem to match the error you're getting.  No "do" for
> example.
>
> I'll try and reproduce it, but haven't seen this before, and the nearest
> gcc version I have easily to hand is 3.4.3
>
> Kieran
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel