WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] compile error of HVM pv drivers

To: "Kieran Mansley" <kmansley@xxxxxxxxxxxxxx>
Subject: RE: [Xen-devel] compile error of HVM pv drivers
From: "Zhao, Yunfeng" <yunfeng.zhao@xxxxxxxxx>
Date: Mon, 30 Jul 2007 20:43:33 +0800
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 30 Jul 2007 05:41:17 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1185789517.4287.10.camel@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcfSkD4DIV1+CdjkTzaut2RMgVcJSAAFpwRw
Thread-topic: [Xen-devel] compile error of HVM pv drivers

>
>490:   list_for_each_entry_safe(vif_state, tmp,
>491:                            &accelerator->vif_states,
>492:                            link) {
>493:           /* Make sure there are no data path operations going on
*/
>494:           netif_poll_disable(vif_state->np->netdev);
>495:           netif_tx_lock_bh(vif_state->np->netdev);
>
>Which doesn't seem to match the error you're getting.  No "do" for
>example.
>
>I'll try and reproduce it, but haven't seen this before, and the
nearest
>gcc version I have easily to hand is 3.4.3
[Yunfeng]  The code I have is the same as yours.
netif_tx_lock_bh is a inline function which contains a macro of LOCK_HB
#define __LOCK(lock) \
  do { preempt_disable(); __acquire(lock); (void)(lock); } while (0)

#define __LOCK_BH(lock) \
  do { local_bh_disable(); __LOCK(lock); } while (0)

>
>Kieran

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel