WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH][SVM] HVM fix for SWINT event injection

To: "Woller, Thomas" <thomas.woller@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH][SVM] HVM fix for SWINT event injection
From: Keir Fraser <keir@xxxxxxxxxxxxx>
Date: Fri, 27 Jul 2007 16:57:15 +0100
Delivery-date: Fri, 27 Jul 2007 08:55:08 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <683860AD674C7348A0BF0DE3918482F605801851@xxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcfQYzPKvOx6lNgtT0G0uq8JV8aZRwAA5lXu
Thread-topic: [Xen-devel] [PATCH][SVM] HVM fix for SWINT event injection
User-agent: Microsoft-Entourage/11.3.3.061214
On 27/7/07 16:31, "Woller, Thomas" <thomas.woller@xxxxxxx> wrote:

> Please apply to xen-unstable.
> Applies cleanly to c/s 15651.
> Signed-off-by Tom Woller <thomas.woller@xxxxxxx>

The right thing to do here is copy the exitintinfo->eventinj only if
eventinj.fields.v==0. And to add a comment that in future the two events
should be 'merged' in the architecturally correct manner (e.g., turned into
#DF in some cases).

At least I *think* this is the right thing to do -- but now I think about
it, is it actually ever okay to copy a SWINT from exitintinfo into eventinj?
At the time the #PF vmexit happens, will EIP have been incremented across
the SWINT instruction? If not, does eventinj of a SWINT correctly cause EIP
to be incremented?

> Note that HVM guests will not boot on AMD-V with xen-staging.hg c/s
> 15652.  
> Keir, do you want me to take a look at staging c/s 15652 on AMD-V w/
> HVM?

Yes please!

 Thanks,
 Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel