WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] [XEND] Modprobe vlan support before trying to us

To: John Levon <levon@xxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] [XEND] Modprobe vlan support before trying to use vconfig
From: Stefan Berger <stefanb@xxxxxxxxxx>
Date: Thu, 26 Jul 2007 11:50:12 -0400
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <keir@xxxxxxxxxxxxx>
Delivery-date: Thu, 26 Jul 2007 08:47:55 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20070726134357.GB18835@xxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

xen-devel-bounces@xxxxxxxxxxxxxxxxxxx wrote on 07/26/2007 09:43:57 AM:

> On Thu, Jul 26, 2007 at 09:47:42AM -0400, Stefan Berger wrote:
>
> > +def linux_enable_vlan():
> > +    global modprobed_8021q
>
> could this please go in osdep.py with the rest of the OS-specific
> stuff*, and just have an osdep.enable_vlan() function?


Now after these other two patches that I just committed, the problem with the vlan creation is gone and the only benefit of such a function osdep.enable_vlan() would be to print out a warning message into the log file to indicate that VLAN support is not available on the system (after a failed modprobe). Not sure whether it is worth such a function, though, but might be useful for debugging. Comments?

   Stefan

>
> thanks
> john
>
> * well, apart from all the new Linux-specific code there is...
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>