WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Xendomain Bug

To: Henning Sprang <henning_sprang@xxxxxx>
Subject: Re: [Xen-devel] Xendomain Bug
From: Henning Sprang <henning_sprang@xxxxxx>
Date: Sun, 22 Jul 2007 13:33:13 +0200
Cc: Xen <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <keir@xxxxxxxxxxxxx>
Delivery-date: Sun, 22 Jul 2007 04:30:56 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <46922744.60403@xxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C2B7B21B.12107%keir@xxxxxxxxxxxxx> <46922744.60403@xxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Icedove 1.5.0.10 (X11/20070329)
Henning Sprang wrote:
> Keir Fraser wrote:
>> Changeset 15384 in xen-unstable (committed on June 19th) should fix this
>> issue.

Hmm, there is still one question left:

The fix I proposed is a patch of about two lines - as can be seen here:
http://bugzilla.xensource.com/bugzilla/show_bug.cgi?id=859

The fix you took in was much larger instead - in fact 2 lines vs. 20.

see: http://xenbits.xensource.com/xen-unstable.hg?rev/865c4ae59be3

Is there something totally wrong with the small patch that I oversaw?

Not that I have the urgent need to get my own patches in, but I usually
tend to think smaller patches should be better, and having less code to
maintain is better - and if I propose bad things, I want to know about it :)

Henning


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>