 Home |
Products |
Support |
Community |
News |
xen-devel
RE: [Xen-devel] Will hap_alloc fail?
| To: | "Huang2, Wei" <Wei.Huang2@xxxxxxx>, "Tim Deegan" <Tim.Deegan@xxxxxxxxxxxxx> |
|---|---|
| Subject: | RE: [Xen-devel] Will hap_alloc fail? |
| From: | Mats Petersson <mats@xxxxxxxxxxxxxxxxx> |
| Date: | Thu, 12 Jul 2007 18:19:00 +0100 |
| Cc: | xen-devel@xxxxxxxxxxxxxxxxxxx |
| Delivery-date: | Tue, 17 Jul 2007 05:07:15 -0700 |
| Dkim-signature: | a=rsa-sha1; c=relaxed/relaxed; d=googlemail.com; s=beta; h=domainkey-signature:received:received:x-mailer:date:to:from:subject:cc:in-reply-to:references:mime-version:content-type:sender:message-id; b=hzkNT+jP8Ct7YhC5WFzDBiaqZAAtZz4YAom5U03mzUd0zLqPA1uxIIdWJwVXgd1bH8FK/N4uZ9cR4FbfI0IgUzfjNjkKCA9358xdQXLv8yMXFM6EtbCMmBNm7W3AMlO0ZAxCp2w10esut8Ax81RBhH7juu57Xwf3TmlDJ59x36w= |
| Domainkey-signature: | a=rsa-sha1; c=nofws; d=googlemail.com; s=beta; h=received:x-mailer:date:to:from:subject:cc:in-reply-to:references:mime-version:content-type:sender:message-id; b=sPQfvizbgOnmIhoNZwPt5ssQnih3edQeZzLbKlM7LfRDo0Fsy45PB70hueghHuaRFF0BKqHm6ZVCsO3zbWdbgs/pntm2FoiaHU9El2W6vvV1ez8zCupHdBU9go38QRPyWcY3uXk6/x+JeK4XI1EZwgffLfA8o0p2H0NKZnplArY= |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <7D748C767B7FA541A8AC5504A4C89A2303AD187E@xxxxxxxxxxxxxxxxx > |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <B30DA1341B0CFA4893EF8A36B40B5C5D01634178@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <B30DA1341B0CFA4893EF8A36B40B5C5D0163417A@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20070712095651.GC2993@xxxxxxxxxxxxxxxxxxxxx> <7D748C767B7FA541A8AC5504A4C89A2303AD183E@xxxxxxxxxxxxxxxxx> <20070712163911.GD2993@xxxxxxxxxxxxxxxxxxxxx> <7D748C767B7FA541A8AC5504A4C89A2303AD187E@xxxxxxxxxxxxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
At 18:14 12/07/2007, Huang2, Wei wrote: Tim Deegan wrote: > At 11:34 -0500 on 12 Jul (1184240066), Huang2, Wei wrote: >> How does this fix sound? > > I think we need somaething that crashes just the guest in question -- > this patch just replaces a probable pagefault crash with an explicit > BUG(). Do you think domain_crash() work here? Or you want some way to propagate error information from hap_alloc() to upper levels? Note: I'm not speaking on behalf of ANYONE here.I would have thought that domain_crash() is the right thing to do - there's nothing "better" that can be done elsewhere, as far as I can understand, and there's really no point in propagating an error unless there's something that can be done about it (or it can be ignored, which isn't the case in this instance), as this only leads to potential misses of the propagated error, making it harder to debug. -- Mats Thanks, -Wei _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] [RFC][PATCH][0/2] Intel(r) Trusted Execution Technology, Jonathan M. McCune |
|---|---|
| Next by Date: | [Xen-devel] Shadow pagetable code, Yongjun Jeon |
| Previous by Thread: | RE: [Xen-devel] Will hap_alloc fail?, Huang2, Wei |
| Next by Thread: | Re: [Xen-devel] Will hap_alloc fail?, Tim Deegan |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
