| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
Re: [Xen-devel] [patch 03/44] usermodehelper: split setup from execution
|
To: |
Rusty Russell <rusty@xxxxxxxxxxxxxxx> |
|
Subject: |
Re: [Xen-devel] [patch 03/44] usermodehelper: split setup from execution |
|
From: |
Jeremy Fitzhardinge <jeremy@xxxxxxxx> |
|
Date: |
Mon, 16 Jul 2007 17:57:34 -0700 |
|
Cc: |
Randy Dunlap <randy.dunlap@xxxxxxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Jeremy Fitzhardinge <jeremy@xxxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Andi Kleen <ak@xxxxxxx>, lkml <linux-kernel@xxxxxxxxxxxxxxx>, David Howells <dhowells@xxxxxxxxxx>, Bj?rn Steinbrink <B.Steinbrink@xxxxxx> |
|
Delivery-date: |
Mon, 16 Jul 2007 17:56:21 -0700 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<1184632870.5955.26.camel@xxxxxxxxxxxxxxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
References: |
<20070716231536.937393000@xxxxxxxxxxxxx> > <20070716232912.409821000@xxxxxxxxxxxxx>> <1184632870.5955.26.camel@xxxxxxxxxxxxxxxxxxxxx> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
|
User-agent: |
Thunderbird 2.0.0.4 (X11/20070615) |
Rusty Russell wrote:
> The patch seems fine, but the names are awkward. They've always been
> awkward (it's *userspace* helper, not *usermode* helper), but this just
> shines a bright light on them.
>
> So how about:
>
> call_usermodehelper_setup -> create_userspace_helper
> call_usermodehelper_<SET_EXTRA_STATE> -> userspace_helper_...
> call_usermodehelper_exec -> run_userspace_helper
>
> I can do that as a separate patch if you prefer (but it'd be nice to
> have it in the same merge window so the interface only churns once).
I don't have any particular objection, but I think it would be nicer if
they had a common prefix so that they're obviously related, and you can
easily infer the lifetime of the info structure.
J
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
| <Prev in Thread] |
Current Thread |
[Next in Thread>
|
- [Xen-devel] [patch 00/44] Xen guest support for 2.6.23, Jeremy Fitzhardinge
- [Xen-devel] [patch 04/44] Add common orderly_poweroff(), Jeremy Fitzhardinge
- [Xen-devel] [patch 01/44] add kstrndup, Jeremy Fitzhardinge
- [Xen-devel] [patch 02/44] add argv_split(), Jeremy Fitzhardinge
- [Xen-devel] [patch 03/44] usermodehelper: split setup from execution, Jeremy Fitzhardinge
- [Xen-devel] [patch 10/44] paravirt: unstatic leave_mm, Jeremy Fitzhardinge
- [Xen-devel] [patch 12/44] paravirt: make siblingmap functions visible, Jeremy Fitzhardinge
- [Xen-devel] [patch 08/44] paravirt: add a hook for once the allocator is ready, Jeremy Fitzhardinge
- [Xen-devel] [patch 05/44] usermodehelper: Tidy up waiting, Jeremy Fitzhardinge
- [Xen-devel] [patch 06/44] use elfnote.h to generate vsyscall notes., Jeremy Fitzhardinge
- [Xen-devel] [patch 13/44] paravirt: export __supported_pte_mask, Jeremy Fitzhardinge
- [Xen-devel] [patch 17/44] Add nosegneg capability to the vsyscall page notes, Jeremy Fitzhardinge
- [Xen-devel] [patch 14/44] Allocate and free vmalloc areas, Jeremy Fitzhardinge
|
|
|
| |
|
Home