WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 4/4] [XEND] add scsihost interface

To: Tomonari Horikoshi <t.horikoshi@xxxxxxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 4/4] [XEND] add scsihost interface
From: Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>
Date: Sun, 15 Jul 2007 13:34:36 +0900
Delivery-date: Sat, 14 Jul 2007 21:32:38 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <78C7C540C3707Dt.horikoshi@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <78C7C540C3707Dt.horikoshi@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Hi Tomonari,

I have two comments. 

XendDevices.py:
@@ -36,6 +36,7 @@ class XendDevices:
 
     controllers = {
         'vbd': blkif.BlkifController,
+       'scsihost': scsihostif.SCSIHostController,
         'vif': netif.NetifController,
         'vtpm': tpmif.TPMifController,
         'pci': pciif.PciController,

The added line includes a tab.


main.py:
@@ -2213,6 +2262,10 @@ def xm_block_detach(args):
         except:
             pass
         detach(args, 'tap')
+
+def xm_scsihost_detach(args):
+    arg_check(args, "xm_scsihost_detach", 2, 3)
+    detach(args, 'scsihost-detach', 'scsihost')
 
 def xm_network_detach(args):
     if serverType == SERVER_XEN_API:

The number of argument of detach() is two. 
'scsihost-detach' is unnecessary. 


Best regards,
 Kan

>
>[PATCH 4/4] [XEND] add scsihost interface
>
>
>Best regards,
>Tomonari Horikoshi
>
>
>-------------------------------text/plain-------------------------------
>_______________________________________________
>Xen-devel mailing list
>Xen-devel@xxxxxxxxxxxxxxxxxxx
>http://lists.xensource.com/xen-devel


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>