WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [patch] crashkernel allocation failure #1

To: Xen Development Mailing List <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] [patch] crashkernel allocation failure #1
From: Gerd Hoffmann <kraxel@xxxxxxxxxx>
Date: Fri, 22 Jun 2007 11:39:02 +0200
Delivery-date: Mon, 25 Jun 2007 09:32:37 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 1.5.0.12 (X11/20070530)
  Hi,

The kexec crash kernel area allocation code does some effort to move the images (i.e. kernel+initrd) out of the way, so the crashkernel area can be allocated at the default location (@16m).

In case initial_images_end is not page aligned a single page in the middle of the crash kernel area is leaked though, making the whole move effort fail.

The attached patch fixed that by rounding up initial_images_end to the next page boundary.

please apply,
  Gerd
--- xen/arch/x86/setup.c.fix    2007-05-03 09:40:19.000000000 +0200
+++ xen/arch/x86/setup.c        2007-06-19 11:19:11.000000000 +0200
@@ -453,6 +453,7 @@
     if ( initial_images_start < xenheap_phys_end )
         initial_images_start = xenheap_phys_end;
     initial_images_end = initial_images_start + modules_length;
+    initial_images_end = (initial_images_end + PAGE_SIZE - 1) & PAGE_MASK;
 
     move_memory(initial_images_start, 
                 mod[0].mod_start, mod[mbi->mods_count-1].mod_end);
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [patch] crashkernel allocation failure #1, Gerd Hoffmann <=