WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] x86: introduce specialized clear_page()

To: <xen-devel@xxxxxxxxxxxxxxxxxxx>,"Keir Fraser" <keir@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] x86: introduce specialized clear_page()
From: "Jan Beulich" <jbeulich@xxxxxxxxxx>
Date: Wed, 20 Jun 2007 16:35:38 +0100
Delivery-date: Wed, 20 Jun 2007 08:33:06 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C29F0340.10F41%keir@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4677C925.76E4.0078.0@xxxxxxxxxx> <C29F0340.10F41%keir@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>>> Keir Fraser <keir@xxxxxxxxxxxxx> 20.06.07 17:16 >>>
>On 19/6/07 11:16, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:
>
>> While the patch also adds an SSE version, this is is currently orphaned
>> as I am not certain about the benefit of special casing idle VCPUs in
>> a few places (during context switching), so that at least in that
>> context using %xmmN registers would be possible without crashing and/or
>> corrupting guest state. The benefit of adding such support could be to
>> reduce scheduling latency when a VCPU is to transition out of idle, but
>> is busy doing page cleaning.
>
>I measure no benefit from the XMM version (nor from upgrading the SSE2
>version on x86/64 to clear from %rax instead of %eax). I guess this is
>because the move is non-temporal and it's actually quite easy to max the
>memory bandwidth.

Neither did I, except (obviously) on machines having SSE, but not SSE2 (which
was what I considered applying this for, with the additional need to tweak
idle vcpu handling so that in that context [where FP context altering doesn't
matter, as long as the rest of the system's aware of it] it could then be used).

>So I stripped out the xmm version (it can't work anyway without some
>kernel_fpu_begin/end kind of mechanism) and made the sse2 version common
>across i386 and x86_64 since that was easily done and increases code
>sharing.

Fine by me - I tried to say this in the description.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel