| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
Re: [Xen-devel] [PATCH 4/4] Add libvdisk, and vdisk_tool
|
To: |
Ben Guthro <bguthro@xxxxxxxxxxxxxxx> |
|
Subject: |
Re: [Xen-devel] [PATCH 4/4] Add libvdisk, and vdisk_tool |
|
From: |
Mark McLoughlin <markmc@xxxxxxxxxx> |
|
Date: |
Tue, 19 Jun 2007 17:10:03 +0100 |
|
Cc: |
xen-devel@xxxxxxxxxxxxxxxxxxx |
|
Delivery-date: |
Tue, 19 Jun 2007 09:08:13 -0700 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<4677D739.3010800@xxxxxxxxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
Organization: |
Red Hat Ltd. Registered Address: Red Hat Ltd, Brian O' Donnell and Partners, 62 Merrion Square, Dublin 2, Ireland. Registered in the Companies Registration Office, Parnell House, 14 Parnell Square, Dublin 1, Ireland, at No. 304873 Directors: Charlie Peters (USA), Michael Cunningham (USA), Matt Parson (USA), Brendan Lane |
|
References: |
<4677D739.3010800@xxxxxxxxxxxxxxx> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
Hi Ben,
On Tue, 2007-06-19 at 09:16 -0400, Ben Guthro wrote:
> diff -r 7cad1f06a7f6 tools/vdisk/vdisk_common.c
...
> + if (vdisk->use_aio) {
...
> + vdisk->ioctx = (io_context_t) REQUEST_ASYNC_FD;
> + vdisk->aio_fd = io_setup(VDISK_HASH_SZ, &vdisk->ioctx);
> + if (vdisk->aio_fd < 0) {
> + VIDDBG(0, "io_setup can't get async poll ID (%s). "
> + " Async IO will not be available\n",
> + strerror(errno));
> + vdisk->use_aio = 0;
> + }
Note that the aio and qcow blktap drivers now use the tapaio wrapper to
poll on aio events, so it'd be nice if this code did the same.
Since the aio code isn't used by qemu, perhaps it'd be better to move
it out of libvdisk and into blktap?
Cheers,
Mark.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home