 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] x86: clear guest's EFLAGS.RF after emulating ins
| To: | Jan Beulich <jbeulich@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] x86: clear guest's EFLAGS.RF after emulating instructions |
| From: | Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> |
| Date: | Tue, 19 Jun 2007 11:19:51 +0100 |
| Delivery-date: | Tue, 19 Jun 2007 03:17:56 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <4677C793.76E4.0078.0@xxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | AceyW18PnaV/jh5OEdyOfAAX8io7RQ== |
| Thread-topic: | [Xen-devel] [PATCH] x86: clear guest's EFLAGS.RF after emulating instructions |
| User-agent: | Microsoft-Entourage/11.3.3.061214 |
On 19/6/07 11:09, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote: >> You set EFLAGS.RF in a few places when injecting #PF. Why would you do that? >> It isn't Xen's job to set that flag ever afaics, and since the original trap >> into Xen was not due to #DB you're not avoiding an infinite loop. > > This is only in handle_mmio() where I cleared the flag earlier - since #PF has > lower > priority than #DB, .RF must have been set when the exception was reported, and > hence I must re-set it when forwarding the exception. Oh, I see. I'm not too familiar with #DB or EFLAGS.RF, but this does appear to make sense given the info in the reference manual. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-devel] [PATCH] use clear_page() where-ever possible/reasonable, Jan Beulich |
|---|---|
| Next by Date: | Re: [Xen-devel] [PATCH] x86: eliminate x86_emulate's private EFLAGS definitions, Jan Beulich |
| Previous by Thread: | Re: [Xen-devel] [PATCH] x86: clear guest's EFLAGS.RF after emulating instructions, Jan Beulich |
| Next by Thread: | [Xen-devel] [PATCH] x86: eliminate x86_emulate's private EFLAGS definitions, Jan Beulich |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
