WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 0/4] [Net] Support accelerated network plugin mod

To: Michael Buesch <mb@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 0/4] [Net] Support accelerated network plugin modules
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Fri, 15 Jun 2007 13:29:58 +0100
Cc: netdev@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, herbert@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 15 Jun 2007 05:25:29 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <200706151421.01608.mb@xxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcevSOK+IQWfUhs8EdyfcQAWy6hiGQ==
Thread-topic: [Xen-devel] [PATCH 0/4] [Net] Support accelerated network plugin modules
User-agent: Microsoft-Entourage/11.3.3.061214


On 15/6/07 13:21, "Michael Buesch" <mb@xxxxxxxxx> wrote:

>> True in general, but not the cases I've seen in this patchset, where 'foo'
>> is a predicate.
> 
> Ok, if foo is a variable containing an error code, it's
> better to return that error code. I assumed that foo is a
> variable containing some value (counter or something).

I mean specifically things like:
 if (be->accelerator == NULL)
    return 1;
 else
    return 0;

 K.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel