WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Make Xen headers lint-clean

To: <john.levon@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Make Xen headers lint-clean
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Fri, 15 Jun 2007 09:30:39 +0100
Delivery-date: Fri, 15 Jun 2007 01:26:11 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <b9d1affca0ff606998ae.1181862120@xenbld>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcevJ3QdsmFCFhsaEdyfcQAWy6hiGQ==
Thread-topic: [Xen-devel] [PATCH] Make Xen headers lint-clean
User-agent: Microsoft-Entourage/11.3.3.061214
On 15/6/07 00:02, "john.levon@xxxxxxx" <john.levon@xxxxxxx> wrote:

> Make ring.h and xs_wire.h lint clean. Add an unused attribute to xsd_errors if
> using GCC, so we don't get duplicate arrays in every object including the
> header.

Casting memset() to void is completely barking. Noone ever cares about the
return value, or looks at it: is half the C code in the universe not lint
clean therefore?

And xsd_errors[] already has the unused attribute; this patch does not add
it as the changeset comment suggests. Do you require to use that header file
with a compiler other than gcc?

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>