 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] PATCH: Use name instead of pid in QEMU logs
| To: | "Daniel P. Berrange" <berrange@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] PATCH: Use name instead of pid in QEMU logs |
| From: | Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> |
| Date: | Tue, 12 Jun 2007 17:04:58 +0100 |
| Delivery-date: | Tue, 12 Jun 2007 09:00:34 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <20070612145927.GI3031@xxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | AcetC2yBqttHsBj+EdyRIgAWy6hiGQ== |
| Thread-topic: | [Xen-devel] PATCH: Use name instead of pid in QEMU logs |
| User-agent: | Microsoft-Entourage/11.3.3.061214 |
On 12/6/07 15:59, "Daniel P. Berrange" <berrange@xxxxxxxxxx> wrote: > All domain names should be validated by XenD to contain printable characters > only - they are displayed & used all over the place in numerous tools where > having non-printale characters will cause plenty of trouble. > > As for overwriting the log file with a domain autorestart after a crash, the > logfile ought to be opened in append mode (w+ instead of w) - logrotate > scripts can handle cleanup of logfiles > > I am happy to submit further patches to validate domain names in XenD and > switch to opening the file in append mode, if changeset 15219 were to be > reverted. Personally I don't much care either way. Christian didn't like the names in log filenames, and he maintains the qemu patchset. :-) -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] PATCH: Use name instead of pid in QEMU logs, Mark Williamson |
|---|---|
| Next by Date: | Re: [Xen-devel] PATCH: Use name instead of pid in QEMU logs, Keir Fraser |
| Previous by Thread: | Re: [Xen-devel] PATCH: Use name instead of pid in QEMU logs, Mark Williamson |
| Next by Thread: | Re: [Xen-devel] PATCH: Use name instead of pid in QEMU logs, Keir Fraser |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
