 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] Add callgraph support to Xenoprofile
| To: | "Keir Fraser" <keir@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] Add callgraph support to Xenoprofile |
| From: | "Amitabha Roy" <amitabha.roy@xxxxxxxxx> |
| Date: | Thu, 7 Jun 2007 14:50:28 +0530 |
| Cc: | Xen developers mailing list <xen-devel@xxxxxxxxxxxxxxxxxxx>, "Santos, Jose Renato G" <joserenato.santos@xxxxxx> |
| Delivery-date: | Thu, 07 Jun 2007 02:18:34 -0700 |
| Dkim-signature: | a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=DGQarx+Cj7TmA3yaXUKtFP79ZYA/YCxRNZbCG9YAMbH8SOdmSlKSjIJ+Kn+LRjDcdo0jztzNVoopFYo1HZLJ1FLsUqe3mnwTI5PmI9xVRPb4XtnUiHPrkbJhR7QOScWcbp1RtQ7nLAiBF6vhJmfIDTkS+4O5lONaEY8/GT52lp8= |
| Domainkey-signature: | a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=PimB0qeJafByKRhG/wZY+Km6aepMbgwljnSD354G9pF9ZRaWAMnAHOML9KxOVPcS/vosOKP1tG+teeGRJ+E3hp/oQa5yvAiViyWUxKHgEsuV2tgZyYNhTMpb0rveoxSdZJ7TR2FImG75vP2OgRqG2bij8i4kvF9PFk4PtUeSBM4= |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <C28D8809.10399%keir@xxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <cf9d85500706062034m311f3a56r5b5aaaa988f6cf43@xxxxxxxxxxxxxx> <C28D8809.10399%keir@xxxxxxxxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
Hi Keir Coding style is likely because I've preserved the formatting of the original files (esp. of backtrace.c from Linux for simple diffs). There isnt a consistent style across the files that I could follow. CONFIG_FRAME_POINTER gets used in config/StdGNU.mk. I simply followed whatever was done for XEN_TARGET_X86_PAE. However unlike the PAE case I haven't ensured that frame pointers are turned on both in the kernel and Xen. If you want I can move all the frame pointer related stuff into xen/Rules.mk. -Amitabha On 6/7/07, Keir Fraser <keir@xxxxxxxxxxxxx> wrote: On 7/6/07 04:34, "Amitabha Roy" <amitabha.roy@xxxxxxxxx> wrote: > This patch implements backtrace support in Xenoprofile. It's been > reviewed by Renato. I've tested it out successfully on xen x86_32 and > x86_64. I've added stubs for the backtrace for ia64 to ensure that it > compiles ok but havent been able to test that out. However, I believe > there shouldn't be any problems. Coding style is all over the shop. Where does CONFIG_FRAME_POINTER get used? I'm not sure that FRAME_POINTER needs to be a top-level option -- it's only necessary for Xen build isn't it? -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] [PATCH] Add callgraph support to Xenoprofile, Keir Fraser |
|---|---|
| Next by Date: | Re: [Xen-devel] [PATCH][xend] Fix handling of scheduler params, Masaki Kanno |
| Previous by Thread: | Re: [Xen-devel] [PATCH] Add callgraph support to Xenoprofile, Keir Fraser |
| Next by Thread: | Re: [Xen-devel] [PATCH] Add callgraph support to Xenoprofile, Keir Fraser |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
