| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
Re: [Xen-devel] [patch 21/33] xen: Xen SMP guest support
|
To: |
Jan Beulich <jbeulich@xxxxxxxxxx> |
|
Subject: |
Re: [Xen-devel] [patch 21/33] xen: Xen SMP guest support |
|
From: |
Jeremy Fitzhardinge <jeremy@xxxxxxxx> |
|
Date: |
Wed, 06 Jun 2007 01:33:18 -0700 |
|
Cc: |
Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Andi Kleen <ak@xxxxxxx>, lkml <linux-kernel@xxxxxxxxxxxxxxx>, Chris Wright <chrisw@xxxxxxxxxxxx>, virtualization@xxxxxxxxxxxxxx, Benjamin LaHaise <bcrl@xxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx> |
|
Delivery-date: |
Wed, 06 Jun 2007 01:31:41 -0700 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<46667FA3.76E4.0078.0@xxxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
References: |
<20070522140941.802382212@xxxxxxxx> <20070522141252.611887616@xxxxxxxx> <46667FA3.76E4.0078.0@xxxxxxxxxx> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
|
User-agent: |
Thunderbird 1.5.0.10 (X11/20070302) |
Jan Beulich wrote:
>> --- a/arch/i386/xen/time.c
>> +++ b/arch/i386/xen/time.c
>> @@ -105,17 +105,15 @@ static void get_runstate_snapshot(struct
>> preempt_enable();
>> }
>>
>> -static void setup_runstate_info(void)
>> +static void setup_runstate_info(int cpu)
>> {
>> struct vcpu_register_runstate_memory_area area;
>>
>> - area.addr.v = &__get_cpu_var(runstate);
>> + area.addr.v = &per_cpu(runstate, cpu);
>>
>> if (HYPERVISOR_vcpu_op(VCPUOP_register_runstate_memory_area,
>> smp_processor_id(), &area))
>>
>
> Shouldn't this be 'cpu' rather than 'smp_processor_id()'?
>
Yes. I'd noticed that, thought it got fixed later in the series, and
looks like I ultimately got confused. Not sure when this crept in; it
has been correct in the past.
J
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home