WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [RFC] Coding style and standardisation

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [RFC] Coding style and standardisation
From: Mark Williamson <mark.williamson@xxxxxxxxxxxx>
Date: Mon, 4 Jun 2007 06:03:44 +0100
Cc: Keir Fraser <keir@xxxxxxxxxxxxx>
Delivery-date: Sun, 03 Jun 2007 22:01:53 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.9.6
Hi all,

The coding style in the Xen tree is somewhat varied these days - there are a 
few deviations from the "standard" that have crept in over time.  I've been 
trying to think of ways we can help contributors understand how the code is 
supposed to look in a canonical form, rather than people trying to judge from 
code already there.

Attached is a little extra documentation - my quick stab at summing up the Xen 
coding style.  I think the main points of difference from the Linux coding 
style are summarised here, but if anybody has anything else they think should 
be included (or anything they disagree with in my summary) it would be handy 
to know.

I've also attached a modified-for-Xen version of a (the?) Linux patch style 
checker.  It might not be 100% accurate, but it should give folks a pretty 
good idea of any obvious style changes they need to make.

My hope is that this will reduce review burden (for reviewers and submitters) 
and eventually get the codebase back towards a uniform coding style.  This is 
a component of my exploration of automated code quality checking for the Xen 
codebase.

Comments, anyone?

Cheers,
Mark

-- 
Dave: Just a question. What use is a unicyle with no seat?  And no pedals!
Mark: To answer a question with a question: What use is a skateboard?
Dave: Skateboards have wheels.
Mark: My wheel has a wheel!

Attachment: xenstyle.patch
Description: all/allfiles

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>