This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] [xm] Fix vncdisplay for hvm guests

To: Keir Fraser <keir@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] [xm] Fix vncdisplay for hvm guests
From: Jim Fehlig <jfehlig@xxxxxxxxxx>
Date: Thu, 24 May 2007 10:42:52 -0600
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 24 May 2007 09:41:18 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: C27B6060.F751%keir@xxxxxxxxxxxxx
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird (X11/20070221)
Keir Fraser wrote:

On 16/5/07 00:14, "Jim Fehlig" <jfehlig@xxxxxxxxxx> wrote:

results in '-vncunused' being passed to qemu-dm.  There are several
for a fix - this patch defaults vncdisplay to None in xm options.  It
currently defaults to 1 and is always included in the image config
created by configure_hvm() in tools/python/xen/xm/create.py.  In xend
(tools/python/xen/xend/image.py - parseDeviceModelArgs), vncunused takes
precedence over vncdisplay.

Looks like it changes vncunused default rather than vncdisplay. Wouldn't the
preferred default be to keep vncunused=1?

Sorry, the wording was a little off in the original post. Right, it does change vncunused to None - not vncdisplay. But the patch was against 3.1.0 and the logic in parseDeviceModelArgs has changed between 3.1.0 and current unstable. In unstable it looks as though vncunused will not be default if it _and_ vncdisplay are not set - which is the case in 3.1.0.

Further, I did not verify the default behavior for pv domains if neither vncunused or vncdisplay is set :-/. I will verify behavior of vncunused vs vncdisplay in unstable and repost patch if necessary.


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>