WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Re: [PATCH 3/4] [Net] Support Xen accelerated network pl

To: Kieran Mansley <kmansley@xxxxxxxxxxxxxx>, Keir Fraser <keir@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] Re: [PATCH 3/4] [Net] Support Xen accelerated network plugin modules
From: Keir Fraser <keir@xxxxxxxxxxxxx>
Date: Tue, 22 May 2007 15:07:09 +0100
Cc: muli@xxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, Stephen Hemminger <shemminger@xxxxxxxxxxxxxxxxxxxx>, herbert@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 22 May 2007 07:05:41 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1179837868.28562.22.camel@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcecenxgusZnOwhtEdy5qgAX8io7RQ==
Thread-topic: [Xen-devel] Re: [PATCH 3/4] [Net] Support Xen accelerated network plugin modules
User-agent: Microsoft-Entourage/11.3.3.061214
On 22/5/07 13:44, "Kieran Mansley" <kmansley@xxxxxxxxxxxxxx> wrote:

>> Eagerly zap the function pointers, then wait one RCU period so every CPU
>> goes through a quiescent point before unloading the module?
>> 
>>  -- Keir
> 
> Am I right in thinking that if one of the functions that was protected
> by RCU was to block, that would be a bad thing?  Clearly the data path
> hooks can't/don't block, but I'm not sure it's so obvious for things
> like probing a new device.

Are there still module reference counts? If so, functions which may block
can manipulate their module's reference count.

Or if not, I guess the accelerator module can have a private reference count
checked by whatever unload function gets called from the RCU subsystem. So
that unload becomes deferred until *both* an RCU phase has passed *and* a
reference count has fallen to zero.

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>