This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[XenPPC] [XEN][TOOLS][PATCH] Add one more error reason statement to blkt

To: xen-ppc-devel@xxxxxxxxxxxxxxxxxxx, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [XenPPC] [XEN][TOOLS][PATCH] Add one more error reason statement to blktapctrl
From: Christian Ehrhardt <ehrhardt@xxxxxxxxxxxxxxxxxx>
Date: Tue, 22 May 2007 09:58:41 +0200
Delivery-date: Tue, 22 May 2007 00:56:50 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-ppc-devel-request@lists.xensource.com?subject=help>
List-id: Xen PPC development <xen-ppc-devel.lists.xensource.com>
List-post: <mailto:xen-ppc-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ppc-devel>, <mailto:xen-ppc-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ppc-devel>, <mailto:xen-ppc-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-ppc-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird (X11/20070301)
I had an issue with blktapctrl on xen-ppc.
The reason is easy - currently we have no blktap in our linux tree, but because blktapctrl did not print out a useful error statement in my case I struggled a while to find the reason. I also saw no useful module error messages because it is not damaged, its just not there in my case. This patch adds an error message if xc_find_device_number fails, all other goto's to open_failed have already their error output, this just adds one more.


Grüsse / regards, Christian Ehrhardt

IBM Linux Technology Center, Open Virtualization
+49 7031/16-3385

IBM Deutschland Entwicklung GmbH
Vorsitzender des Aufsichtsrats: Johann Weihen Geschäftsführung: Herbert Kircher Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294

# HG changeset patch
# User Christian Ehrhardt <ehrhardt@xxxxxxxxxxxxxxxxxx>
# Date 1179814369 -7200
# Node ID 6d25bbfcb3e2ce7660b5253431b0b9638d1df1bc
# Parent  be31124bbec216693cb5758ee2e6d87b3fd292b2
[XEN][TOOLS][PATCH] Add one more error reason statement to blktapctrl
blktapctrl already prints out exits reasons for all goto's to open_failed 
except of not finding a device number for blktap0
This patch adds just that message so the user will get more info than just 
"Unable to start blktapctrl"
Common source of this issue is that blktap is missing/failed to load/...
Signed-off-by: Christian Ehrhardt <ehrhardt@xxxxxxxxxxxxxxxxxx>

diff -r be31124bbec2 -r 6d25bbfcb3e2 tools/blktap/drivers/blktapctrl.c
--- a/tools/blktap/drivers/blktapctrl.c Mon May 07 05:44:46 2007 +0200
+++ b/tools/blktap/drivers/blktapctrl.c Tue May 22 08:12:49 2007 +0200
@@ -690,8 +690,10 @@ int main(int argc, char *argv[])
        /* Attach to blktap0 */
        asprintf(&devname,"%s/%s0", BLKTAP_DEV_DIR, BLKTAP_DEV_NAME);
-       if ((ret = xc_find_device_number("blktap0")) < 0)
+       if ((ret = xc_find_device_number("blktap0")) < 0) {
+               DPRINTF("couldn't find device number for 'blktap0'\n");
                goto open_failed;
+    }
        blktap_major = major(ret);
        ctlfd = open(devname, O_RDWR);
Xen-ppc-devel mailing list
<Prev in Thread] Current Thread [Next in Thread>
  • [XenPPC] [XEN][TOOLS][PATCH] Add one more error reason statement to blktapctrl, Christian Ehrhardt <=